commit
message
Removing COVARIANCEP and COVARIANCES because they're not in GS. Might bring them back later.
author
Ben Vogt <[email protected]>
date
2017-02-20 17:11:40
stats
3 file(s) changed,
7 insertions(+),
17 deletions(-)
files
README.md
src/RawFormulas/RawFormulas.ts
tests/FormulasTest.ts
1diff --git a/README.md b/README.md
2index 5b82e97..86093f8 100644
3--- a/README.md
4+++ b/README.md
5@@ -8,12 +8,6 @@ Things I should do.
6 * Write more thorough tests for all formulas
7 * Include fail state values for all formulas
8
9-### Write formulas for missing ones
10-* FDIST
11-* FINV
12-* SUM_ formulas
13-* ACCRINT
14-
15 ### SUM and SUMA should be different, and I'm pretty sure they're currently the same.
16
17 ### Date-Time issues
18@@ -34,4 +28,9 @@ arbitrary javascript is executed in the client machine.
19
20 ### License for all code used.
21
22-### Document the functions pulled in from jStat.
23\ No newline at end of file
24+### Document the functions pulled in from jStat.
25+
26+### Bring back missing Excel functions
27+* COVARIANCEP
28+* COVARIANCES
29+* ...etc.
30\ No newline at end of file
31diff --git a/src/RawFormulas/RawFormulas.ts b/src/RawFormulas/RawFormulas.ts
32index 1a513cd..f82d7f8 100644
33--- a/src/RawFormulas/RawFormulas.ts
34+++ b/src/RawFormulas/RawFormulas.ts
35@@ -109,8 +109,6 @@ var ACCRINT = Formula["ACCRINT"];
36 var COMBIN = Formula["COMBIN"];
37 var CONVERT = Formula["CONVERT"];
38 var CORREL = Formula["CORREL"];
39-var COVARIANCEP = Formula["COVARIANCEP"];
40-var COVARIANCES = Formula["COVARIANCES"];
41 var CUMIPMT = Formula["CUMIPMT"];
42 var CUMPRINC = Formula["CUMPRINC"];
43 var DATE = Formula["DATE"];
44@@ -175,8 +173,6 @@ export {
45 COUNTIF,
46 COUNTIFS,
47 COUNTUNIQUE,
48- COVARIANCEP,
49- COVARIANCES,
50 CUMIPMT,
51 CUMPRINC,
52 DATE,
53diff --git a/tests/FormulasTest.ts b/tests/FormulasTest.ts
54index 6df35ea..32737b5 100644
55--- a/tests/FormulasTest.ts
56+++ b/tests/FormulasTest.ts
57@@ -2,7 +2,7 @@ import { ABS, ACCRINT, ACOS, ACOSH, ACOTH, AND, ARABIC, ASIN, ASINH, ATAN, ATAN2
58 AVERAGEA, AVERAGEIF, BIN2DEC, BIN2HEX, BIN2OCT, CEILING,
59 CHAR, CODE, COMBIN, CONCATENATE, CONVERT,
60 CORREL, COS, PI, COSH, COT, COTH, COUNT, COUNTA, COUNTIF, COUNTIFS, COUNTUNIQUE,
61- COVARIANCEP, COVARIANCES, CUMIPMT, CUMPRINC, DATE, DATEVALUE, DAY, DAYS, DAYS360,
62+ CUMIPMT, CUMPRINC, DATE, DATEVALUE, DAY, DAYS, DAYS360,
63 DB, DDB, DEC2BIN, DEC2HEX, DEC2OCT, DEGREES, DELTA, DEVSQ, DOLLAR, DOLLARDE, DOLLARFR, EDATE,
64 EFFECT, EOMONTH, ERF, ERFC, EVEN, EXACT, EXPONDIST, FINV, FALSE, FLOOR, __COMPLEX, FISHER, FISHERINV, IF,
65 INT, ISEVEN, ISODD, LN, LOG, LOG10, MAX, MAXA, MEDIAN, MIN, MINA, MOD, NOT, TRUE, ODD, OR,
66@@ -649,10 +649,6 @@ catchAndAssertEquals(function() {
67 }, ERRORS.NA_ERROR);
68
69
70-assertEquals(COVARIANCEP([3,2,4,5,6], [9,7,12,15,17]), 5.2);
71-
72-assertEquals(COVARIANCES([2,4,8], [5,11,12]), 9.666666666666668);
73-
74 assertEquals(CUMIPMT(0.12, 12, 100, 1, 5, 0), -54.39423242396348);
75
76 assertEquals(CUMPRINC(0.12, 12, 100, 1, 5, 0), -26.324171373034403);